Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run docker build only for master branch #734

Merged
merged 1 commit into from
Jan 31, 2022
Merged

Run docker build only for master branch #734

merged 1 commit into from
Jan 31, 2022

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Jan 25, 2022

Enable filters to run docker build only on master branch.
(Disabled in #733)

@alpe alpe requested a review from ethanfrey January 25, 2022 14:05
ethanfrey
ethanfrey approved these changes Jan 25, 2022
View reviewed changes
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

We can wait a bit to merge it if you want. I think it is fine to only run there, but we should look at the big red X on master sometime... I ignored this as well (it is on the main wasmd page)

@ethanfrey ethanfrey merged commit 7625caf into master Jan 31, 2022
@alpe alpe deleted the docker_master_builds branch May 10, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfrey ethanfrey ethanfrey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alpe @ethanfrey